On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite
> a lot of code duplication. The test code can be simplified e.g. by using
> generics. Additionally the test failure output was improved and a test for
> the constructors of CertPathBuilderException was added.
Changes requested by mullan (Reviewer).
test/jdk/java/security/Exceptions/ChainingConstructors.java line 40:
> 38: private static Exception cause = new Exception("cause");
> 39:
> 40: public static void main(String[] args) throws Exception {
I would add the bugid to line 26 since you are adding an additional test for
CertPathBuilderException.
test/jdk/java/security/Exceptions/ChainingConstructors.java line 208:
> 206: throw new SecurityException("Test 17 failed");
> 207: }
> 208: */
I don't know why this is commented out, but when I uncomment it, the test still
passes, so I would include a test for `SSLException` below.
-------------
PR: https://git.openjdk.org/jdk/pull/11016
