On Fri, 16 Sep 2022 00:27:55 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
> Hi,
>
> Please review this simple fix for readability.
>
> In the AES cipher implementation, the AESCipher class is defined as abstract.
> As is not necessary as there is no abstract method in this class. Code
> reader may try to search for abstract methods if the abstract keyword is
> present.
>
> BTW, I also added Override tags and make a few other cleanup, for example
> adding the 'final' keywords.
>
> Thanks,
> Xuelei
Two minor nits, but otherwise looks good.
src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 61:
> 59: */
> 60:
> 61: class AESCipher extends CipherSpi {
If you're doing general cleaning, line 33 import ByteBuffer can go, and there's
an extra line in the javadoc at line 53 that could also go.
-------------
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10297
