On Tue, 15 Nov 2022 16:00:36 GMT, Weijun Wang <[email protected]> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use hash algorithm for RSASSA-PSS
>
> test/micro/org/openjdk/bench/java/security/Signatures.java line 39:
>
>> 37: @Fork(jvmArgsAppend = {"-Xms1024m", "-Xmx1024m", "-Xmn768m",
>> "-XX:+UseParallelGC"}, value = 3)
>> 38: public class Signatures {
>> 39: private static Signature signer;
>
> Not a JMH expert. Is it possible to make `Signatures` abstract and move the
> ECDSA codes into a subclass just like for other algorithms?
I had the same concerns about the style. But I did not find a way to make it.
-------------
PR: https://git.openjdk.org/jdk/pull/11131
