On Mon, 14 Nov 2022 18:41:41 GMT, Sean Mullan <mul...@openjdk.org> wrote:
> Yes. I believe the `setEagerValidation` method can also be removed and all > code that calls it. OK, I will remove it and all methods that calls it:  . Because `JarVerifier#setEagerValidation` will be removed, the field `eagerValidation` will always be false. There are some codes using this field: https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/jar/JarVerifier.java#L361-L381 Can I remove the `eagerValidation` condition from `if(eagerValidation && sigFileSigners.get(name) != null)`? https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/jar/JarFile.java#L1229-L1247 Can I remove the `if (jv.eagerValidation) {}` code block? Can I remove this field from `JarVerifier`? ------------- PR: https://git.openjdk.org/jdk/pull/11072