On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> This is mostly cleanup. Everything around `DerOutputStream` no longer throws
>> an `IOException`. This includes:
>>
>> - Remove unnecessary `throws IOException` in code and spec
>> - Remove `catch (IOException ioe)` blocks. If new exception is thrown,
>> remove further `throws` in code and spec
>> - More classes implementing `DerEncoder` if they have a
>> `encode(DerOutputStream)` method
>> - Modify `write(bytes)` to `writeBytes(bytes)` to avoid IOE
>> - Some unused methods removed
>> - `DerOutputStream` is final
>>
>> The only actual changes (still trivial) are:
>> - Since `PKCS7::encodeSignedData(OutputStream out)` is removed, its usages
>> in `PKCS7::constructToken` and `TsaSigner::createResponse` (in test) are
>> modified to use another method with a `DerOutputStream` argument.
>> - In PKCS8Key, since `getEncodedInternal` never returns non-null, remove
>> null check on result
>> - Since `DerOutputStream` is final, no need to clone bytes in `encode` of
>> `X509CertImpl` and `X509CRLImpl`.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> one more
src/java.security.jgss/share/classes/sun/security/jgss/spnego/NegTokenTarg.java
line 77:
> 75: }
> 76:
> 77: final byte[] encode() throws GSSException {
Probably no need for GSSException?
src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java line 99:
> 97: }
> 98:
> 99: private void makeEncoding(byte[] s) throws InvalidKeyException {
No need for the InvalidKeyException?
src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java line 113:
> 111: }
> 112:
> 113: private void makeEncoding(BigInteger s) throws InvalidKeyException {
No need for the InvalidKeyException?
-------------
PR: https://git.openjdk.org/jdk/pull/11302
