Hi, While reviewing the JarWithOneNonDisabledDigestAlg test, I found that the code could perhaps be easier to follow if some updates would be made in the choice of keystore naming and choice of algorithms.
I also found potential for some more general code cleanups, and also a way to move expectations of signing counts out of checkThatJarIsSigned method. Knowing well that this fixes no bug, I wanted to hear what people think about the usefulness of such changes before I go the JBS route with a proper PR. Here's a draft PR with my proposed changes: https://github.com/openjdk/jdk/pull/11997 Cheers, Eirik.