On Thu, 16 Feb 2023 18:31:30 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in
>> one base class (SSLContextTemplate)
>> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible.
>> * Updated SSLEngineTemplate to accommodate changes in SSLContextTemplate. To
>> keep this changeset to a reasonable size, updates to SSLEngine tests will be
>> made under JDK-8301194.
>
> test/jdk/javax/net/ssl/ALPN/SSLServerSocketAlpnTest.java line 31:
>
>> 29: * @bug 8051498 8145849 8158978 8170282
>> 30: * @summary JEP 244: TLS Application-Layer Protocol Negotiation Extension
>> 31: * @compile MyX509ExtendedKeyManager.java
>
> Suggest you to delete file `MyX509ExtendedKeyManager.java` if it is not
> needed anymore.
removed
> test/jdk/javax/net/ssl/TLSCommon/TLSWithEdDSA.java line 266:
>
>> 264: */
>> 265: @Override
>> 266: public SSLContext createClientSSLContext() throws Exception {
>
> Why is this change needed, may be unintentional?
reverted the file
> test/jdk/javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2011, 2023, Oracle and/or its affiliates. All rights
>> reserved.
>
> Can you please check test
> `sun/security/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java` as this
> template test was a copy of it? Suggest you to check if this template copy
> can be removed now as we have other template classes for SSLSocket/SSLEngine
> client and server.
Removed SSLSocketSSLEngine.java
-------------
PR: https://git.openjdk.org/jdk/pull/12555
