On Fri, 4 Jun 2021 06:51:35 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi, >> >> I need a review of this rather large change to GCM. GCM will no longer use >> CipherCore, and AESCrypt to handle it's buffers and other objects. It is >> also a major code redesign limits the amount of data copies and make some >> performance-based decisions. >> >> Thanks >> >> Tony > > Anthony Scarpino has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 29 commits: > > - merge, and a few nits > - Merge branch 'master' into perfphase1 > - left 4k test length for trigger > - missed resultLen and undo decrypt heap hasarray check > - code review comments > - fix > - Remove GCTR reset() calls because GCTR is released after the operation > some variable name consistency > other small cleanup > - Review comments update > - Review comments update > - Fix perf problem by reorganizing doLastBlock() > - ... and 19 more: https://git.openjdk.org/jdk/compare/b9558655...d84d302b > It is also a major code redesign limits the amount of data copies and make > some performance-based decisions. Out of curiosity, what kind of perf improvement should one expect as a result of these changes? ------------- PR: https://git.openjdk.org/jdk/pull/4072
