On Thu, 11 May 2023 06:14:10 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> serialization fixes, more code shaping
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 165:
>
>> 163: }
>> 164:
>> 165: static class LMSUtils {
>
> It might be simpler and more efficient to use enum for lms and lmots types.
I had considered that and decided not to use it. In my opinion, Java Enum is
much more complicated than it should be for this case. Efficiency is not a
concern here, but I also don't see how enum could be more efficient.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1190690480
