On Tue, 16 May 2023 16:28:26 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > to and length and comments src/java.base/share/classes/javax/crypto/KEM.java line 233: > 231: * of the shared secret as a 128-bit AES key. > 232: * @throws IndexOutOfBoundsException if {@code from < 0}, > 233: * {@code from > to}, or {@code to > secretSize()} Shouldn't this say "{@code to - from > secretSize()}"? src/java.base/share/classes/javax/crypto/KEM.java line 356: > 354: * decapsulation process > 355: * @throws IndexOutOfBoundsException if {@code from < 0}, > 356: * {@code from > to}, or {@code to > secretSize()} Shouldn't this say "{@code to - from > secretSize()}"? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1196042549 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1196043626