On Sun, 14 May 2023 05:50:20 GMT, Tagir F. Valeev <[email protected]> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308016: Remove ellipses ("...") from snippets
>
> src/java.base/share/classes/java/io/RandomAccessFile.java line 904:
>
>> 902: * {@code b7}, and {@code b8,} where:
>> 903: * {@snippet lang=java :
>> 904: * 0 <= b1, b2, b3, b4, b5, b6, b7, b8 <= 255,
>
> Same: this is not Java language syntax. Code or pre tags are fine here, they
> are not deprecated.
I would keep the snippet markup but change the language to "text"; removing the
expectation of language support.
The benefits of a consistent look are still desirable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13957#discussion_r1196733214
