On Wed, 17 May 2023 12:42:32 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Check return code of SecTrustSettingsCopyTrustSettings and address review >> comments > > src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m line 1: > >> 1: /* > > Regarding CFArrayGetValueAtIndex, when looking at other usages of the > function in the codebase the result is NULL checked usually. Should we do > this here too? I admit the old coding does not have it as well. Hm, can it really be NULL? I mean before we check the array size and then iterate the valid range. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13945#discussion_r1197070738
