On Fri, 19 May 2023 17:49:07 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - fix bug id in test header > - reworked example into a jtreg test test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 48: > 46: > 47: // Test was originally written for TLSv1.2 > 48: private static String proto = "TLSv1.2"; Many of these could final. Some of these are no longer used. test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 86: > 84: * Main entry point for this demo. > 85: */ > 86: public static void main(String args[]) throws Exception { Nit. C Style args here instead of Java style. test/jdk/sun/security/ssl/SSLEngineImpl/Test8294985.java line 104: > 102: } > 103: > 104: static Test8294985 fuzzdemoref = null; No longer used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199338944 PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199339757 PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1199339499
