On Fri, 16 Jun 2023 11:14:38 GMT, Sean Coffey <[email protected]> wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Refactor out security code to helper class
> - Print aliases. Order Provider type/service output.
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 132:
> 130: ResourceBundle.getBundle(defaultBundleName);
> 131: }
> 132: static PrintStream ostream;
I don't think we want SecuritySettings accessing LauncherHelper's field like
this. I assume printSecuritySetting is just missing a PrintStream parameter so
that it can be called to print the security settings to a given stream.
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 276:
> 274: first = false;
> 275: } else { // following lines prefix with indents
> 276: ostream.println(TWOINDENT + s);
I assume these changes are per reverted now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1232121754
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1232121990
