On Thu, 22 Jun 2023 19:50:10 GMT, Jamil Nimeh <jni...@openjdk.org> wrote:
>> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replaced depreciated ctor in putTime. Added getTime method to >> DerInputStream > > test/jdk/sun/security/util/DerOutputStream/DerTimeEncoding.java line 40: > >> 38: //Check that dates after 2050 use GeneralizedTime >> 39: DerOutputStream out = new DerOutputStream(); >> 40: Date generalizedTimeDate = new Date(2055,3,17); > > Same comment as above for both this line and line 50. Don't forget to change these to use the long-based `Date` constructor, also in milliseconds. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14617#discussion_r1239108332