On Wed, 19 Jul 2023 17:28:15 GMT, Valerie Peng <[email protected]> wrote:
>> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_crypt.c line 172:
>>
>>> 170: &ckEncryptedLen);
>>> 171:
>>> 172: if (directIn == 0 && inBufP != NULL) {
>>
>> with this change, inBufP and outBufP should be non-null when directIn ==0
>> and directOut == 0, right? Perhaps we only need to check for one instead of
>> both.
>
> Same goes for the rest of the file. Otherwise, changes look good.
Good point, will remove the extra checks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14931#discussion_r1268416624
