On Thu, 3 Aug 2023 10:04:17 GMT, Sibabrata Sahoo <ssa...@openjdk.org> wrote:
>> test/jdk/sun/security/pkcs11/PKCS11Test.java line 973:
>>
>>> 971: return r;
>>> 972: }
>>> 973:
>>
>> I am not sure if 'NO_DEFAULT' expected to be true in setCommonSystemProps()
>> Line:977 or it need to be explicitly reset by each Test where testDefault()
>> expected to be executed,
>> System.setProperty("NO_DEFAULT", "true");
>>
>> If it is supposed to be true then the testDefault() will always get skipped
>> with the following condition,
>> Line:270-273 is will return before proceeding to test the default provider,
>> if ("true".equals(System.getProperty("NO_DEFAULT"))) {
>> System.out.println("Skip default provider as test configured
>> with NO_DEFAULT");
>> return;
>> }
>
> I see few Tests use "-DNO_DEIMOS=true -DNO_DEFAULT=true" in @run tag when
> they don't want the specific provider to be used. In that case Line:977
> System.setProperty("NO_DEFAULT", "true"); is expected to be "false"?
There is no change to this logic. Yes, some tests are configured to Skip Deimos
and Default run. It is inconsistent as few tests call setCommonSystemProps()
and others are setting System property. But, this update has no change to this
code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15125#discussion_r1283491277
