On Thu, 10 Aug 2023 17:51:41 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address review feedbacks
>
> test/jdk/sun/security/pkcs11/MessageDigest/TestCloning.java line 26:
>
>> 24: /*
>> 25: * @test
>> 26: * @bug 6414899 8242332 8312428
>
> No need to add bug id for test only updates.
Ok.
> test/jdk/sun/security/pkcs11/MessageDigest/TestCloning.java line 67:
>
>> 65: } catch (CloneNotSupportedException cnse) {
>> 66: // skip test if clone isn't supported
>> 67: System.out.println("=> Clone not supported; skip!");
>
> Can you please update the test to throw SkippedException if no digest
> algorithms are found to not support clone? This would help us with coverage
> analysis.
Do you mean throw SkippedException if no digest algorithms are actually tested
with Clone functionality testing? Existing NSS impl seems to support clone for
non-SHA-3 digest impls.
> test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java line 51:
>
>> 49: public void main(Provider p) throws Exception {
>> 50: if (!PSSUtil.isSignatureSupported(p)) {
>> 51: System.out.println("Skip testing RSASSA-PSS" +
>
> Update to throw SkippedException.
Ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1290542665
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1290546013
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1290546289
