On Mon, 11 Sep 2023 09:38:44 GMT, Claes Redestad <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 201:
>>
>>> 199: * @return index of the most significant digit or minus sign, if
>>> present
>>> 200: */
>>> 201: public static int getChars(int i, int index, byte[] buf) {
>>
>> It's unused now. Do we expect usages to be added in following PRs?
>
> These weren't in `java.util.DecimalDigits` but have been copied from
> `java.lang.StringLatin1` - part of an unfinished refactoring? There's no
> clear-cut answer where these best fits but it seems reasonable to keep them
> in `StringLatin1` and `StringUTF16` respectively.
> It's unused now. Do we expect usages to be added in following PRs?
I plan to provide the getChars method in this PR and use it in my other PR
#15555. I also plan to submit another PR to optimize java.time toString, and I
will also use this method.
https://github.com/wenshao/jdk/commit/cc82e8c11aeb27c0f8581363f7133c85f6022ca1
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15651#discussion_r1321338873
