On Mon, 11 Sep 2023 23:20:04 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

> I am not sure that it is a good thing to modify the JDK when many tests are 
> executed in parallel. But for now, I updated the test, it will be skipped if 
> the setup stage fails.

Whoa. Is this test running by default? I guess we are saved by the fact 
`POLICY_DIR` is in separate directory, so this probably does not affect other 
tests. But I agree, it is risky to modify tested JDK. 

Sean makes a [comment 
here](https://bugs.openjdk.org/browse/JDK-8286779?focusedCommentId=14520807#comment-14520807)
 about rewriting the test like this one: 
[java/security/Security/ConfigFileTest.java](https://github.com/openjdk/jdk/blob/8b4f9a88e606c4c6722061ce9946ce17340ff1df/test/jdk/java/security/Security/ConfigFileTest.java)
 -- is it easy enough to do here?

-------------

PR Review: https://git.openjdk.org/jdk/pull/15674#pullrequestreview-1622063971

Reply via email to