On Wed, 20 Sep 2023 06:08:11 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added test to check that when keystore.type is null it defaults to pkcs12 > > test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 34: > >> 32: * KeyStore.getDefaultType() value is related to property value. Expect >> a full >> 33: * match the value 'keystore.type' and the value of the >> 34: * KeyStore.getDefaultType() > > I don't quite get the summary... Actually the test does not set any value to > the "keystore.type" property. Thus, it seems a little strange to expect a > full match to KeyStore.getDefaultType()? Changed to "Set keystore.type as null and check that KeyStore.getDefaultType() returns pkcs12" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1331836703
