On Fri, 22 Sep 2023 13:02:57 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Why not just updating UnexpectedNPE test with `Utils.runAndCheckException` >> calls? > > I was just thinking the tests are quite different. Now I re-read it and maybe > we can change the old code to call `generateCRLs` as well. The existing > `encoded_x` are very simple and only invalid SEQUENCES, which is not at the > level of X.509 or PKCS7. > > Therefore I'm OK with reusing this test without the `generateCRL` flag. And leave `Utils.runAndCheckException` out of the fix? I'm fine either way. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15844#discussion_r1334564687
