On Sat, 30 Sep 2023 06:26:10 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> Prepares java.security.jgss for the permissive- compiler switch by
>
> - Adding scopes so goto doesn't jump over unitialized locals in sspi.cpp
> - Adding a static modifier to a mismatched method declaration in
> NativeCreds.c, as the definition is static
Changes requested by djelinski (Reviewer).
src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 39:
> 37:
> 38: #include <windows.h>
> 39: #include <cstdlib>
This seems unrelated; my MSVC doesn't complain about these headers.
The C form is still preferred, even in our CPP code. Can we leave this change
out?
src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 372:
> 370: SEC_WCHAR* value = new SEC_WCHAR[len + 1];
> 371:
> 372: {
This is ugly. I'm not a fan of braces appearing in the middle of the code for
no apparent reason.
[This SO
question](https://stackoverflow.com/questions/31513798/error-jump-to-label-foo-crosses-initialization-of-bar)
states that we can fix the compilation errors by splitting inline
initialization into definition + assignment. I think I'd prefer that approach.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15996#pullrequestreview-1652256933
PR Review Comment: https://git.openjdk.org/jdk/pull/15996#discussion_r1342380436
PR Review Comment: https://git.openjdk.org/jdk/pull/15996#discussion_r1342375351
