On Mon, 2 Oct 2023 20:00:03 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rewrite method comment > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1435: > >> 1433: >> 1434: /* >> 1435: * Assemble the entry attributes > > Perhaps be a bit more specific here - "Populate the entry with additional > attributes used by the implementation." Will add. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15909#discussion_r1343160611