On Mon, 16 Oct 2023 16:23:13 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Remove most `System.exit()` calls in various security tools and only leave
>> one in the `main` method. This paves the way to convert them to JSR 199
>> tools.
>>
>> Note: before this change, the behavior of a successful `main()` method
>> execution is not consistent. Sometimes the method returns silently,
>> sometimes a `System.exit(0)` is called somewhere. After this change, the
>> method always returns silently. This makes sure that existing programs that
>> calls the `main` method directly will continue and does not exit the VM.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> inline some throw statements, remove duplicated whitespaces
src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Kinit.java
line 131:
> 129: } catch (Exception e) {
> 130: String msg;
> 131: if (e instanceof KrbException) {
Let's simplify with pattern matching variable
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15951#discussion_r1364260468
