On Thu, 2 Nov 2023 18:43:19 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > code review comments Looks good to me. BTW, have you considered making `truststore` a password-less pkcs12 file? Then there is no need to provide a password for it. You can create one with `-J-Dkeystore.pkcs12.certProtectionAlgorithm=NONE -J-Dkeystore.pkcs12.macAlgorithm=NONE` when calling the `keytool -importkeystore` command. ------------- Marked as reviewed by weijun (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16159#pullrequestreview-1711150221