On Tue, 28 Nov 2023 00:49:58 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line >> 792: >> >>> 790: >>> 791: /* >>> 792: * Optimized version of bufferCrypt from CipherSpi.java. Direct >> >> Can you document the optimizations done in this function? > > The second sentence says what the optimizations is. well I was under the impression that the bulk of the optimization comes from using modified `engineGetOutputSize` that does not allocate when isUpdate== true and decrypting. That's not documented anywhere. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16487#discussion_r1407396658
