On Tue, 19 Dec 2023 19:19:35 GMT, Roger Riggs <[email protected]> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Better name for a label, corrected name of removed field.
>
> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
> line 108:
>
>> 106: SUID_NAME + " should be declared of type long");
>> 107: }
>> 108: if (!isStatic(f)) {
>
> The two calls to isStatic could be reordered closer together to be a single
> if (isstatic()) { ... } else {... }.
I guess you are looking to an older commit?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1432581987
