> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.com/openjdk/jdk/pull/15996, but this is simply a hack and does > not address the real issue of gotos jumping over locals. I've as such fixed > the issues with them properly this time, by simply deleting the labels and > duplicating the code where they're used. As mentioned, this unfortunately > does increase duplicate code, but is the cleanest solution I could come up > with for the labels
Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Fix the remaining case in sspi.cpp ------------- Changes: - all: https://git.openjdk.org/jdk/pull/16682/files - new: https://git.openjdk.org/jdk/pull/16682/files/8b4a3005..926bc9aa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16682&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16682&range=05-06 Stats: 13 lines in 1 file changed: 9 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/16682.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16682/head:pull/16682 PR: https://git.openjdk.org/jdk/pull/16682
