On Wed, 10 Jan 2024 02:53:15 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 321: >> >>> 319: >>> 320: this.oid = oid; >>> 321: info = oidMap.get(oid); >> >> What if `info` is `null` (there is no entry for the specified OID)? The >> prior code set the value class to `byte[]` in that case. I think we want to >> preserve that behavior. > > So, it seems that no test is triggering a NPE? Consider adding a test for > covering this scenario? This was caught by `sun/security/pkcs/pkcs9/UnknownAttribute.java` and has been fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17132#discussion_r1449521516
