On Thu, 11 Jan 2024 18:15:43 GMT, Matthew Donovan <[email protected]> wrote:
>> I was unable to recreate the error but it looks like the problem could
>> happen if two instances of the test are run on the same machine. Also, if
>> the deleteEntry() calls in the finally block throw an exception, they can
>> hide any exceptions thrown earlier in the test.
>>
>> I updated the test to use randomly generated alias names. I also updated the
>> finally block so exceptions thrown by deleteEntry() are logged but not
>> thrown.
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains two additional
> commits since the last revision:
>
> - Merge branch 'master' into keytool-alias
> - 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias
> <246810> does not exist"
This LGTM with minor comment to update bound and update copyright year.
test/jdk/sun/security/mscapi/KeytoolChangeAlias.java line 40:
> 38: public static void main(String[] args) throws Exception {
> 39: SecureRandom random = new SecureRandom();
> 40: String alias = Integer.toString(random.nextInt(1000, 9999));
Limit this bound to the power of 2 value - 8192 to avoid re-calculation?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17352#issuecomment-1896320620
PR Review Comment: https://git.openjdk.org/jdk/pull/17352#discussion_r1456212192
