On Fri, 26 Jan 2024 10:04:11 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Please review this patch that fixes a memory leak in P11TlsPrfGenerator, > which is triggered during TLS1.2 Finished message generation and verification. > > The patch changes C_SignInit JNI method to free the mechanism data > immediately after use. This matches the behavior of other Init methods (like > C_EncryptInit). The patch also fixes a similar issue in other > signature-related methods. > > The change essentially reverts part of > [JDK-8080462](https://bugs.openjdk.org/browse/JDK-8080462). > > All sun/security/pkcs11 tests still pass with NSS ~3.35 and~ 3.91. All > tier1-3 tests still pass. > > EDIT: > Some sun/security/pkcs11 tests fail with NSS 3.64 and older, see > [comment](https://github.com/openjdk/jdk/pull/17584#issuecomment-1914665234) This pull request has now been integrated. Changeset: 68206b53 Author: Daniel Jeliński <djelin...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/68206b533b09e07e4d556df794414ed4538889c0 Stats: 109 lines in 7 files changed: 25 ins; 65 del; 19 mod 8324585: JVM native memory leak in PCKS11-NSS security provider Reviewed-by: valeriep ------------- PR: https://git.openjdk.org/jdk/pull/17584
