On Fri, 16 Feb 2024 11:27:52 GMT, Darragh Clarke <[email protected]> wrote:
>> Currently these tests ignore vm flags, In most cases I've updated them to >> use `ProcessTools.createTestJavaProcessBuilder` this usually required some >> cleanup also. >> >> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and >> `test/jdk/java/net/URLConnection/6212146/TestDriver.java` have been set to >> use `@require vm.flagless` because they both use `sh` commands. >> >> I've ran these changes against tiers 1-3 and everything seems stable > > Darragh Clarke has updated the pull request incrementally with two additional > commits since the last revision: > > - Update test/jdk/java/net/ServerSocket/AcceptInheritHandle.java > > Co-authored-by: Andrey Turbanov <[email protected]> > - fixed copyright year Marked as reviewed by jpai (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/17787#pullrequestreview-1884898745
