On Fri, 16 Feb 2024 15:11:06 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> In this PR I updated the tests to use the newer
>> ProcessTools.createTestJavaProcessBuilder() methods to launch child
>> processes. This method ensures that VM options are passed to subprocesses.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> reverted ModuleName and SignedJarWithCustomClassLoader to use
> createLimitedTestJavaProcessBuilder
test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java line
1023:
> 1021: String... args) throws Throwable {
> 1022: String[] cmd = new String[args.length + 5];
> 1023: cmd[0] = jdkPath + "/bin/java";
This method passed in `jdkPath` and it could be another JDK other than the one
we are testing with.
test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java line
1045:
> 1043: cmd[2] = "-J-Duser.country=US";
> 1044: System.arraycopy(jvmArgs,0, cmd, 3, jvmArgs.length);
> 1045: System.arraycopy(args, 0, cmd, 3 + jvmArgs.length,
> args.length);
Again, this tool might come from a previous version of JDK. it's possible that
options for the current JDK do not work with it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17877#discussion_r1497822289
PR Review Comment: https://git.openjdk.org/jdk/pull/17877#discussion_r1497827533
