On Thu, 14 Mar 2024 13:43:01 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Change `Krb5LoginModule` debugging to use `sun.security.util.Debug`.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> just use true
src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoToken.java
line 30:
> 28: import org.ietf.jgss.GSSException;
> 29: import sun.security.jgss.GSSToken;
> 30: import sun.security.util.Debug;
Is this really needed?
src/java.security.jgss/share/classes/sun/security/krb5/internal/KerberosTime.java
line 36:
> 34: import sun.security.krb5.Config;
> 35: import sun.security.krb5.KrbException;
> 36: import sun.security.util.Debug;
Needed?
src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/crc32.java
line 33:
> 31: package sun.security.krb5.internal.crypto;
> 32:
> 33: import sun.security.krb5.internal.Krb5;
It's not obvious to me why this import is needed.
src/jdk.security.auth/share/classes/com/sun/security/auth/module/Krb5LoginModule.java
line 1015:
> 1013: } catch (Exception e) {
> 1014: lcreds = null;
> 1015: if (debug != null)
Might want to add curley braces here and elsewhere.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525380205
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525354378
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525326097
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525165817
