On Tue, 19 Mar 2024 14:01:14 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Load root certificates from SystemRootCertificates.keychain
>
> Is it practical to add a test as described in the bug?:
> 
> `java -Djavax.net.ssl.trustStoreType=KeychainStore-ROOT 
> HttpsURLConnectionTest https://github.com/`
> 
> This could be added to the `test/jdk/security/infra` test directory since it 
> depends on an external server.

> Hi @seanjmullan Thank you for review I've added the test

Thanks. @rhalade Is this an acceptable place (security/infra) to put a test 
that makes external network connections?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16722#issuecomment-2012619601

Reply via email to