On Fri, 12 Apr 2024 14:12:56 GMT, Weijun Wang <[email protected]> wrote:
>> The CC can be loaded with any file and its name is not static.
>>
>> `MemoryCredentialsCache` is removed since it's not used anywhere. We've
>> already supported native ccache reading directly with JNI method
>> `Credentials::acquireDefaultNativeCreds`.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> copyright years
src/java.security.jgss/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java
line 163:
> 161: synchronized void load() throws IOException, KrbException {
> 162: try (FileInputStream fis = new FileInputStream(localCacheName);
> 163: CCacheInputStream cis = new CCacheInputStream(fis)) {
nit: fix indentation here?
src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java
line 150:
> 148: target = cc;
> 149: name = cc.cacheName();
> 150: } else
nit: can you add {} for this block?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13737#discussion_r1566533419
PR Review Comment: https://git.openjdk.org/jdk/pull/13737#discussion_r1566534285
