On Thu, 11 Apr 2024 16:29:00 GMT, Ben Perez <[email protected]> wrote:
> Updated `getService` to check whether `getProvider` returns null when
> checking for preferred providers and `continue` the loop if that is the case.
> Added `NullPreferredList` test.
The change looks good, just some tiny comments. Also, please add newlines to
the end of the 2 new files.
src/java.base/share/classes/sun/security/jca/ProviderList.java line 378:
> 376: if (p == null) {
> 377: continue;
> 378: }
Not related to this cod change, but the `getAll` line on line 373 will never
return null.
test/jdk/sun/security/jca/NullPreferredList.java line 2:
> 1: /*
> 2: * Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights
> reserved.
New test, remove `2014, `.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18746#pullrequestreview-2006072620
PR Review Comment: https://git.openjdk.org/jdk/pull/18746#discussion_r1568858319
PR Review Comment: https://git.openjdk.org/jdk/pull/18746#discussion_r1568858952
