On Thu, 9 May 2024 20:19:41 GMT, Weijun Wang <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 53:
>
>> 51: * and Expand-only variants.
>> 52: */
>> 53: abstract class HkdfKeyDerivation extends KDFSpi {
>
> How about just name it `HKDF`?
Make this class `sealed`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595930055
