On Fri, 10 May 2024 13:08:00 GMT, Alan Bateman <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 2625:
>
>> 2623: * @since 23
>> 2624: */
>> 2625: public final SecretKey exportKey(byte[] context, String algorithm,
>> int length) {
>
> You've probably thought about this already but adding a final method to a
> non-final class with an accessible constructor is source and binary
> incompatible.
Thanks. I'll change it to non-final. I just hope nobody uses the same name with
same arguments but different return type in their subclasses. Seems not likely.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18409#discussion_r1596759662
