On Wed, 8 May 2024 20:25:36 GMT, Sean Mullan <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comment
>
> src/java.base/share/classes/java/security/Provider.java line 1607:
>
>> 1605: addEngine("SecretKeyFactory", false, null);
>> 1606: addEngine("KEM", true, null);
>> 1607: addEngine("KDF", true,
>
> For the 2nd argument to be true, the HKDF provider implementation should
> probably register some additional service attributes as defined in
> https://docs.oracle.com/en/java/javase/22/docs/specs/security/standard-names.html#service-attributes
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597008145
