On Mon, 13 May 2024 15:23:59 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java 
>> line 148:
>> 
>>> 146:         }
>>> 147: 
>>> 148:         return null;
>> 
>> Should it throw exception instead of null? Also it will never reach here.
>
> An exception is better, yes.

see: 4a0405abd12

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598665526

Reply via email to