On Mon, 13 May 2024 14:12:17 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/sun/security/util/Debug.java line 142:
>
>> 140: System.err.println(" only dump output for the
>> specified list");
>> 141: System.err.println(" of JCA engines. Supported
>> values:");
>> 142: System.err.println(" Cipher, KDF, KeyAgreement,
>> KeyGenerator,");
>
> Do we also need to add the option name itself? Somewhere neat line 100.
I'll keep this one open for now.
> test/jdk/com/sun/crypto/provider/KDF/TestHKDFInitialization.java line 1:
>
>> 1: /*
>
> Why the class name? Is this only about initialization?
I'll probably remove this test before the PR is merged.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599146261
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599147522
