On Tue, 14 May 2024 18:52:59 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > javadoc updates src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 69: > 67: HkdfKeyDerivation(String hmacAlgName, int hmacLen, > 68: AlgorithmParameterSpec algParameterSpec) > 69: throws InvalidAlgorithmParameterException { I think you missed an earlier comment from @wangweij where this ctor should throw an IAPE if params != null. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1600531156
