On Tue, 14 May 2024 23:17:48 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   re-enable Delayed Provider test
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java 
> line 97:
> 
>> 95:             throw new InvalidParameterSpecException(
>> 96:                 "the algorithm for the resultant SecretKey may not be 
>> null or"
>> 97:                 + " empty");
> 
> I think this should be an `IllegalArgumentException`.

Agreed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1601936499

Reply via email to