On Mon, 27 May 2024 16:28:31 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
> Please review this PR, which supersedes a now withdrawn > https://github.com/openjdk/jdk/pull/14831. > > This PR replaces `ArraysSupport.vectorizedHashCode` with a set of more > user-friendly methods. Here's a summary: > > - Made the operand constants (i.e. `T_BOOLEAN` and friends) and the > `vectorizedHashCode` method private > > - Made the `vectorizedHashCode` method private, but didn't rename it. > Renaming would dramatically increase this PR review cost, because that > method's name is used by a lot of VM code. On a bright side, since the method > is now private, it's no longer callable by clients of `ArraysSupport`, thus a > problem of an inaccurate name is less severe. > > - Made the `ArraysSupport.utf16HashCode` method private > > - Moved tiny cases (i.e. 0, 1, 2) to `ArraysSupport` This pull request has now been integrated. Changeset: 3cff588a Author: Pavel Rappo <pra...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/3cff588a3104aa5224e7236eb2c2bb5852de9202 Stats: 266 lines in 13 files changed: 186 ins; 32 del; 48 mod 8332826: Make hashCode methods in ArraysSupport friendlier Reviewed-by: redestad, liach ------------- PR: https://git.openjdk.org/jdk/pull/19414
