On Mon, 17 Jun 2024 19:21:37 GMT, Anthony Scarpino <[email protected]>
wrote:
>>> What causes regression in P256 "(~-8-14%)"? From what I see, you
>>> re-arranged code to not execute some code ("reducePositive()") when it is
>>> not needed. How this affects P256?
>>
>> Actually, the other way around; reducePositive is now an unconditionally
>> executed for both pure java and the intrinsic paths. Perhaps that's what is
>> misleading, it was only the mult() intrinsic that was taking advantage of
>> this 'skip reduction' before. (pure java did not benefit from removing
>> reduction, so I kept it. Now 'keeping it' for both paths)
>
> Hi @vpaprotsk,
> @ferakocz is going to take a look at the change. When he says it's ok, I'll
> approve the PR.
@ascarpino please approve this change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19728#issuecomment-2189546944
