On Mon, 24 Jun 2024 18:26:34 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move variables to above try block
>
> src/java.base/share/classes/com/sun/crypto/provider/FeedbackCipher.java line
> 160:
>
>> 158: int encryptFinal(byte[] plain, int plainOffset, int plainLen,
>> 159: byte[] cipher, int cipherOffset)
>> 160: throws IllegalBlockSizeException, ShortBufferException {
>
> Why was SBE removed?
Because IJ claims SBE is unnecessary, and indeed, this code builds fine without
SBE.
> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 275:
>
>> 273: * This is an intrinsified method. The method's argument list must
>> match
>> 274: * the hotspot signature. This method and methods called by it,
>> cannot
>> 275: * throw exceptions or allocate arrays as it will break intrinsics
>
> Add period to end of sentence.
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1667086270
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1667086294
