On Tue, 9 Jul 2024 21:25:16 GMT, Ben Perez <d...@openjdk.org> wrote:

>> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC 
>> AlgorithmParameters  does not return standard names
>
> Ben Perez has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Moved test, clarified error message, explicitly initialized keypair to 
> secp384r1

src/java.base/share/classes/sun/security/util/ECParameters.java line 1:

> 1: /*

Update the last copyright date to 2024.

test/jdk/com/sun/crypto/provider/AlgorithmParameters/EC/CurveGetParameterSpec.java
 line 38:

> 36:     public static void main(String[] args) throws Exception {
> 37:         KeyPairGenerator kpg = KeyPairGenerator.getInstance("EC");
> 38:         kpg.initialize(384);

Technically this could use another curve that is 384 bits. To make sure it is 
"secp384r1", pass in a `new ECGenParameterSpec("secp384r1")` to `initialize`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20010#discussion_r1672840748
PR Review Comment: https://git.openjdk.org/jdk/pull/20010#discussion_r1672847017

Reply via email to