On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > addressed several review comments, namely: - renaming the getParameters > method - renaming the AlgorithmParameterSpec object - address some javadoc > exception messages - add some information to KDF class private constructor > javadocs - other general cleanup src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 338: > 336: // Calculate the number of rounds of HMAC that are needed to > 337: // meet the requested data. Then set up the buffers we will > need. > 338: hmacObj.init(prk); RFC5869 sec 2.3 states that "PRK - a pseudorandom key of at least HashLen octets". Shouldn't we check it before passing to to `hmacObj`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1719130143
